Jobs entities can't be used after the deletion of an environment#10
Open
danillofb wants to merge 2 commits intowftools:7.x-1.xfrom
Open
Jobs entities can't be used after the deletion of an environment#10danillofb wants to merge 2 commits intowftools:7.x-1.xfrom
danillofb wants to merge 2 commits intowftools:7.x-1.xfrom
Conversation
skwashd
requested changes
Dec 7, 2016
wf_environment/wf_environment.module
Outdated
| ->fields('wf_job') | ||
| ->condition('eid', $env_id) | ||
| ->execute() | ||
| ->rowCount(); |
Member
There was a problem hiding this comment.
This is inefficient as it iterates over the result set. Please use countQuery like so:
$results = db_select('wf_job', 'wf_job')
->fields('wf_job')
->condition('eid', $env_id)
->countQuery()
->execute()
->fetchField();This will use the database's native COUNT() function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.